Nathan Daly

Results 165 comments of Nathan Daly

We learned after asking on the `google/pprof` repo (they replied _very promptly_, which is wonderful! ☺️) that you can enable relative percentages via `-relative_percentages`, and then paths you ignore in...

:) Cool! I just added a flag and verified that it works! :) Will push up now

Ah, okay, it looks like the problem is with the new extra double-quotes around the libname at the end of the shared .dylib build command. This works on my machine:...

Does https://github.com/JuliaPackaging/Yggdrasil/pull/5652 supersede this PR? Does PProf now work even if you don't have graphviz installed? 🎉 thanks Valentin, btw!

I've started work on this, here: https://github.com/JuliaPackaging/Yggdrasil/pull/351

Ah, okay, so i think this is a clue... For some reason, even simple assignment is calling `convert`. Does this make sense?: ```julia julia> x = FixedPointDecimals.FixedDecimal{Int128,2}(3) FixedDecimal{Int128,2}(3.00) julia> @code_warntype...

Ah, okay this issue exactly describes the problem. We're missing a `convert(::Type{FD{T,f}}, x::{FD{T,f}})`: https://github.com/JuliaLang/julia/issues/17559

Ah, actually, no i think it was coming from this widemul: https://github.com/JuliaMath/FixedPointDecimals.jl/blob/d87debb95f30976f572e1ee5deb844f91334adc8/src/FixedPointDecimals.jl#L288-L292 Because `f == g` matches `f ≥ g`. In this case, where the types are identical, no conversion...

Hi again! So we've been poking at this for the last couple weeks, and we've got some significant performance improvements! :) First, though, we've improved the benchmarks we're using to...