Nathan Daly

Results 165 comments of Nathan Daly

That said, I am also very curious about the answer to this question: > how to config '**separate configurations for each learned variation**' ? > ![](https://cloud.githubusercontent.com/assets/382863/19032832/8cad2366-898e-11e6-8800-536520ee7581.png) Does this mean that...

There's nothing in that file? https://github.com/openai/InfoGAN/blob/master/infogan/__init__.py I assume you meant another file.

I'd love to hear the official answer to this question! That said, I managed to get this to work by making this tiny change to `infogan_trainer.py`: In https://github.com/openai/InfoGAN/commit/8fca21e889b5b9b57e0eb3655fbe22a854de0c44, I changed:...

+1 - it seems worth keeping these separate. The implementation in this package is a bit easier to use, I think.

And currently, since the REQUIRE is forcing an old version of Compat, it's difficult / impossible to use this package together with more modern packages that require a newer version...

bumping the status on this one?

Sorry the diff is hard to read; it'll be easier after https://github.com/JuliaTime/TimeZones.jl/pull/344/ is merged. The entirety of this PR is just in this single commit, here: bd68cf9 You can view...

@omus: I think this PR is ready for review whenever you get time. if there's anyone else who you'd prefer to do the review, just let me know. 👍 🙁

> Just wanted to call out that the TimeZone mutex changes is essentially equivalent to a readers/writers lock similar to this implementation: 6522f7a. I'm just calling this out as a...

No worries at all - i fully believe that there are bugs in the implementation here. We actually split this out into its own package, here: https://github.com/NHDaly/MultiThreadedCaches.jl We found several...