ITK icon indicating copy to clipboard operation
ITK copied to clipboard

WIP: Replace "vnl_sample.h" with `<random>` in ConnectedComponent tests

Open N-Dekker opened this issue 2 months ago • 2 comments

  • Another follow-up to pull request #5611

N-Dekker avatar Nov 11 '25 20:11 N-Dekker

  • The first of the two commits (on ConnectedComponent tests) has test failures that I find hard to fix. So I branched off the other one (on Voronoi), which should be easier to get passed: pull request #5624

N-Dekker avatar Nov 11 '25 23:11 N-Dekker

There appeared test failures at https://open.cdash.org/viewTest.php?onlyfailed&buildid=10817138 on the following four tests:

  1. itkConnectedComponentImageFilterTest
  2. itkConnectedComponentImageFilterTest2
  3. itkConnectedComponentImageFilterTest3
  4. itkConnectedComponentImageFilterTestRGB

I'm sorry, I don't really know how to fix them, but I guess we would have to change the ground truth images (somewhere in ${ITK_DATA_ROOT}, in order to make this work. For example, for itkConnectedComponentImageFilterTestRGB: https://github.com/InsightSoftwareConsortium/ITK/blob/6568876c1b5eb3ee398dd69bd1a0e960dcca8da6/Modules/Segmentation/ConnectedComponents/test/CMakeLists.txt#L44-L55

Does anyone have suggestion?

N-Dekker avatar Nov 12 '25 14:11 N-Dekker