Niels Dekker

Results 415 comments of Niels Dekker

Hmmm... PythonTypemapsTest fails on ITK.Linux.Python and ITK.macOS.Python, https://open.cdash.org/test/811897245 says: ``` Exception caught as expected /Users/runner/work/1/s/Modules/Core/Common/src/itkProcessObject.cxx:1339: ITK ERROR: MedianImageFilter(0x7fa3157e0900): Input Primary is required but not set. Traceback (most recent call last):...

> But [PythonTypemapsTest](https://open.cdash.org/test/813223872) still fails. Strange! Obviously this rather simple style improvement cannot be merged until this test passed successfully again! 🤔

> Matt say's "The non-const may be needed in this case." Thanks @dzenanz, but that still makes me wonder why! Normally in C++ a "const" member function may be called...

> I would not consider this a "simple style improvement". It is an API change. @blowekamp Can you please explain? From an end-user perspective, do you see any change?

Still wondering about the error message from https://open.cdash.org/test/813223872 saying: > File "/home/vsts/work/1/s-build/Wrapping/Generators/Python/itk/ITKCommonBasePython.py", line 984, in AddObserver > `if len(args) == 3 and not issubclass(args[2].__class__, itk.Command) and callable(args[2]):` > UnboundLocalError: local...

> Yes. Python is C -- it does not use all the niceties of C++ sometimes. Thanks @thewtex, but sorry, I still don't understand. Does that mean that each and...

Update: I finally start to understand how removing the redundant `Object::AddObserver` overload affects SWIG! When `Object::AddObserver` is overloaded as it has been so far (having a redundant non-const overload), SWIG...

"First interaction / build (pull_request_target)" has failed! Any suggestion? It says: ``` internal/modules/cjs/loader.js:1216 throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath); ^ Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /node_modules/@octokit/graphql/index.js require()...

> The action probably broke again. Hopefully, someone (action author) will fix it soon, without us having to put effort into it. We can ignore this "failure" for the purposes...

Typo: `std::strtoull`! https://www.cplusplus.com/reference/cstdlib/strtoull/ Another option could be `istringstream`, of course: std::string pointsString; size_t address; // Assuming that the address is specified by this specific substring. std::istringstream(pointsString.substr(35)) >> address; Of course,...