Mumfrey
Mumfrey
In theory this should work identically to redirecting a GETFIELD or PUTFIELD, so hopefully yes, but that will be determined when I come to look at it.
This looks sensible, I will take a look at this and validate there are no unexpected side-effects.
This isn't a bad idea to be honest, the contract of transformers is that calls should be idempotent but as you say a few transformers don't respect this obligation. However...
As you've already identified, the scaffolding to support this is already there, but is only used internally. The generated maps would need to be moved to the `build` directory somewhere,...
Of course, although you should bear in mind that the PR document **precedes** the API itself and basically takes a kind of stream-of-consciousness approach to explaining how the API design...
I've had good success with both these methods: - Just symlink the `SpongeCommon` directory in one project to the `SpongeCommon` in the other project. - Set the path to `SpongeCommon`...
> @diesieben07 basically, the fix provided by sponge is wholly incomplete. They also needed to provide an alternative implementation of ClassWriter that avoids the use of Class.forName() in ClassWriter.getCommonSuperClass, so...
I guess that overall it would be a better solution, since the root of the issue is in the assumptions ClassWriter makes about the environment (which are perfectly sensible assumptions,...
@cpw yes, that would be my _starter for 10_. Because it would be an internal ASM used only by Mixin (and of course any mods providing `IMixinConfigPlugin` instances) so I'd...
For the time being I've gone down the route of shading a remapped ASM, I've [put this on a branch for now](https://github.com/SpongePowered/Mixin/tree/feature/shade-asm) until @luacs1998 can give me some feedback on...