Mumfrey

Results 99 comments of Mumfrey

Allow for shadowed fields to be declared using super types

I see exactly what you're trying to do and it's absolutely not a bad use-case. Neither of the proposed solutions are awful either so I will address each: > Ideally,...

Add logging options for failed Mixin application to MixinPlugins

That's true. Even if you didn't know whether the specific failed mixins were "relevant" to a particular crash, you could include the failed list in crash reports for example.

Annotation processor expects full At target signature

Ah yes. The requirement is because the mappings require the descriptor in order to locate the obfucation mapping. There are two things I think can be done to work around...

Initializers of fields added by mixins are added to all constructors, potentially reinitializing fields

I'll consider this a documentation issue since this is absolutely the intended behaviour, field initialisers in mixins are a powerful feature that can actually be used to do some cool...

Provide auditing functionality to assist in locating conflicts

Sure thing, improving auditing in general would probably be a bonus.

Missing toString override in GlobalProperties$Keys causes incorrectly named Keys due to string concatenation with existing Keys

Thanks for opening this, marked as bug.

ForceLoadAsMod causes mod to be loaded twice with latest forge (that includes new dependency extraction)

Ok I will take a look into this. The problem with the FML agent is obviously that it's tightly-coupled to the structure of forge and thus if any internal changes...

Non-trivial initialization of the last declared field declared on multiple lines causes initialization of other fields in the same mixin to not be merged into the target class when using javac

I'll look into this.

References to @Shadow fields declared in super-mixins do not get remapped in dev environment

Thanks for the detailed writeup again, will look into this.

Modify multiple local variables

Not currently, though this is a good idea. It could actually be done in a similar way to how `@ModifyArgs` is done vs. `@ModifyArg`. Effectively adding a new `@ModifyVariables` which...