Mrbroggle

Results 12 comments of Mrbroggle

> Since our colorscheme currently only provides 16 colors, the 256 colors need to converge to them. Depending on the intended behaviour, the mapping from 256 to 16 can be...

I was going to write a whole long winded explantion of how if i wrote this module without hacky work arounds and permission changing it wouldn't work, in the process...

> Does this mean this part can be removed? If we also enable the module by default, we could entirely remove this README.md file. I think we should enable it...

> > > Does this mean this part can be removed? If we also enable the module by default, we could entirely remove this README.md file. > > > >...

> > @trueNAHO please can you check whether the conversations from [your previous review](https://github.com/danth/stylix/pull/951#pullrequestreview-2699629597) should be resolved :)) > > @Mrbroggle, the dark and light themes look the same when...

> @danth, should we use a `home.activation` script? we could use `jq` in home.activation script something like ```bash mv rstudio-prefs.json temp.json jq -r '.editor_theme|= "stylixBase16"' temp.json > rstudio-prefs.json rm temp.json...

all seems to be working now and auto setting the theme. It is installing jq and spone however. Which I though in the way implementend should be temporary just for...

> @Mrbroggle, can you approve commit [c680a63](https://github.com/danth/stylix/commit/c680a63090c4bd82e3ff363f177abd7ee6c3801f) ("rstudio: polish Bash code") and [545f5e3](https://github.com/danth/stylix/commit/545f5e37416b2d66500bc83465bff8c41eb41e17) ("rstudio: add required meta.name attribute")? changes should be applied.

> I couldn't find which part of the template is causing this. I did a test, this issue is here in the mustache file: `/* rs-theme-is-dark: TRUE */` Im not...

I fixed it in a pretty scuffed way, i wasnt too sure how else to do it other than concat the header with the template but its working.