Rico Neubauer

Results 15 comments of Rico Neubauer

Can't argue with that of course. As you can see in the issue though, it has its 2nd birthday in 2 days :-) - so would prefer not investing more...

@pkriens > @NicholasWMRitchie where did you find _any_ documentation about an `Add-Opens` manifest header? Jumping-in: It is documented here: https://openjdk.org/jeps/261#Packaging:-Modular-JAR-files But note: The manifest entries only can be used if...

Thanks for the update @clebertsuconic - 2020 was yesterday from my feeling ;) I still consider it a valuable change improving robustness (helped several times in our environments), but totally...

Following is a proposal - passes the unit test, but not tested furthermore. ``` From 6baad02f2c672cab4cea24db5b3de3a9eae2dc01 Thu, 25 Apr 2019 14:22:27 +0200 From: Rico Neubauer Date: Thu, 25 Apr 2019...

Tested patch - not yet working, needs further adaptions.

@brian-brazil No not really. Would need more time and love to make it fully work.

Agree, it is a bit odd - background: #toString called by ConcurrentSkipListSet, into which the PreparedStatements are inserted for a prepared-statement-cache. Thanks for looking into it.

> What is the purpose of calling `toString` there then? The ``ConcurrentSkipListMap`` does this for comparing the entries (PLStatement below is a wrapper around PreparedStatement)- not knowing of the characteristics...

Thanks for the input rg. the cache - yes will look into it. But it's just an example, basically any developer might decide to call #toString on an object -...

@davecramer you are right, a simple prepare + toString does not reproduce it. It actually has to get invoced twice and also probably the values assigned. The following added test...