MrChico

Results 108 comments of MrChico

Using logs to recover state is not a good practice. I'm not sure that one would want to condone such behaviour

That sounds like recovering state to me. Determining the allowance of a user is easy, you just fetch the corresponding `allowance` from state. Maybe you describe a use case where...

Thanks for everybody's comments. I dont have a strong feeling about this, and it seems like others do. So in the case of this contract one would add another event...

Yeah. Not a fan of 777. Calls to unknown code goes strictly against the praxis of this codebase

The assertion in the code isn't an indication of any uncertainty. It is simply put there for demonstrative purposes, to document the fact that the code is unreachable and to...

@jparklev Seems like there is no way to vote for multiple proposals right now? I would maybe change the logic of `vote` to be decomposed into `vote` and `unvote` by...

I also still feel like there should be timeout to locked balances so that people need to restate their positions for the status quo. Otherwise I think we're gonna see...

> > Seems like there is no way to vote for multiple proposals right now? I would maybe change the logic of vote to be decomposed into vote and unvote...

@xwvvvvwx I agree that it is confusing in the current implementation, but I think the concept is valuable; to be able to signal support for multiple proposals individually makes the...