Tyler Yahn

Results 616 comments of Tyler Yahn

> #### AlignedHistogramBucketExemplarReservoir > > This Exemplar reservoir MUST take a configuration parameter that is the > configuration of a Histogram. This implementation MUST keep the last seen > measurement...

> ### Custom ExemplarReservoir > > The SDK MUST provide a mechanism for SDK users to provide their own > ExemplarReservoir implementation. This extension MUST be configurable on > a...

> > #### Stream configuration > > [...] > > The SDK MUST accept the following stream configuration parameters: > > [...] > > > > * `exemplar_reservoir`: A >...

To address the generics, we can create a `Value` type: ```go type ValueType uint8 const ( UnknownValueType ValueType = 0 Int64ValueType ValueType = 1 Float64ValueType ValueType = 2 ) type...

I'm working to refactor `sdk/metric/internal/exemplar` to match [this](https://github.com/open-telemetry/opentelemetry-go/issues/5249#issuecomment-2093551079) design. That way we can validate it before releasing.

Moving to the v1.28.0 milestone as #5285 needs to be released and used before that code is exported to resolve this.

Blocked by https://github.com/open-telemetry/opentelemetry-go/issues/5542

The plan is to try and get a PR merged with the new public interface right after the next release. That way we have a longer time to evaluate the...

Having those types in an `sdk/metric/exemplar` package makes sense to me. It addresses the dependency issue and it adds an appropriate prefix to most of the types that we need...

If you do not want to use an environment variable, use the [`os.Unsetenv`](https://pkg.go.dev/os#Unsetenv) function.