Tyler Yahn

Results 614 comments of Tyler Yahn

We should check if this is also needed for the attributes in trace/metric pipelines.

> What about using `autoexport`? https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4326

One solution is to have `OnEmit` accept a reference: ```go OnEmit(ctx context.Context, record *Record) error ``` This will mean that every record will need to be allocated to the heap.

Another solution is to have `OnEmit` return a `Record` ```go OnEmit(ctx context.Context, record Record) (Record, error) ``` The returned `Record` can be the same record passed, or a mutated clone...

> I could work on this but it would be nice to have #5093 merged first to reduce the amount of conflicts. Merged

No, I don't think we can close the issue. We are not compatible with the specification. The specification states the log records are mutable and that processors are executed in...

> Where is it defined? In the definition of a read/write record.

> #### Stream configuration > > [...] > > The SDK MUST accept the following stream configuration parameters: > > [...] > > * `exemplar_reservoir`: A > functional type that...

> A Metric SDK MUST provide a mechanism to sample `Exemplar`s from measurements via the `ExemplarFilter` and `ExemplarReservoir` hooks. We do not comply with this.