Mr-Clam

Why is it compiling with `-DPIC` instead of `-fPIC`?

I just tried reproducing this on my Mac and it passed both parameters, so for some reason it's not setting `-fPIC`for you. Can you share more info about your environment?...

There's something about setting $CC and $CXX that trips up the configure script. It even causes it to use different optimisation flags. Can you unset these? Alternatively, can you use...

Unicode is multi-byte. Unicode encoded as UTF-8 is variable length multi-byte at that.

> Unicode is multi-byte. Unicode encoded as UTF-8 is variable length multi-byte at that. This is mostly correct, yet shows zero experience with Visual Studio and Windows. Use Unicode Character...

> I think Visual studio project files should just be removed from the source tree. CMake can be used to generate them. I'd second that. This looks like tedious, manual,...

> > Single set of VS projects will not work for direct use in CI or straight with MSBuild > > Do library maintainers had to apply black magic if...

You're not the only ones to encounter this problem. There's a full patch here in the Microsoft vcpkg repo: https://github.com/microsoft/vcpkg/blob/master/ports/zlib/0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch There are some other handy patches too in the same...

The CMakeLists.txt included with zlib is for building zlib. I'm hoping @imrichardcole is suggesting a [CMake module file](https://cmake.org/cmake/help/book/mastering-cmake/chapter/Modules.html#find-modules) that is distributed with the (pre-)built zlib library that makes it easier...

@tletnes: why was this closed? Do you not think it's not an issue, you plan to fix it as part of something else or you just want to let this...