Johann Dirry
Johann Dirry
I'm not to happy with this `Config` class. The name should be more descriptive, like `ImportDocumentConfiguration`. Further, the `Config.GetConfig()` method should not hardcode where it gets the configuration from. It...
LGTM 💡You could use [Fody.ConfigureAwait](https://github.com/Fody/ConfigureAwait) to make that implicit, since it should be the default for new code anyway.
> Developers can supply delegates that will end up being invoked by the library. Yes that is an issue here. With the `ConfigureAwait(false)` the code will potentially return in a...
A few thoughts: - the `this.` keywords can be safely removed everywhere, since they do not contribute anything. - the exact version of the `Google.Apis.Customsearch.v1` package should not be hardcoded,...
Instead of ```csharp string resultString; if (countInt == 1) { resultString = results.FirstOrDefault() ?? string.Empty; } else { resultString = JsonSerializer.Serialize(results); } return resultString; ``` you could do something like...
LGTM ❗Removing the existing planner is a breaking change that requires a new minor version.
Instead of ```csharp [SKFunction("Get the current date")] public string Today() { // Example: Sunday, 12 January, 2025 return this.Date(); } ``` You could just write ```csharp [SKFunction("Get the current date")]...
I don't like code in the form of `private readonly TEmbedding[]? _vector;` as seen in `Embeddings.cs`. Enumerable objects should return an empty enumerable object like `Array.Empty` when not initialized instead...
LGTM. 💡 A code weaver like [Fody.NullGuard](https://github.com/Fody/NullGuard) or a [Roslyn code generator](https://github.com/dotnet/roslyn/blob/main/docs/features/source-generators.cookbook.md) might be helpful in replacing all those runtime `null` checks.