Christopher Sidebottom
Christopher Sidebottom
@fPecc there's some new conflicts, can you rebase and push again? might also fix CI 😸
Thanks for working through this one @fPecc! This is an awesome improvement and it has now landed 👍
> I would suggest to postponed your current work for 1-2 months till we get done from #2105, then refactoring this work together, and rewriting the C SIMD kernels intrinsics...
I've added the implementation of the hook here as well @jan-wassenberg, and some tests to check it works as I think we discussed 😸
@jan-wassenberg hmm, maybe it just got confused. I also saw some unrelated errors so I've rebased, so it should be a clean diff now 😸
> OK, I see now some of the CI failures: > > ``` > abort.cc:44: error: missing '#include '; '__sanitizer_print_stack_trace' must be declared before it is used > 44 |...
Confused by: ``` ERROR: no such package 'third_party/highway': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a...
@jan-wassenberg I used `GTEST_HAS_DEATH_TEST`, which should be more robust. Did it fail again? If so, I'll add the specific WASM check as well.
> Apologies, missed something the CI found. Our gtest wrapper does not support ASSERT_EQ in abort_test. Would you mind changing to HWY_ASSERT_EQ? No worries, easy fix 😸
I spoke too soon 😿 looks like this is going to be trickier when comparing pointer types 🤔