tvm icon indicating copy to clipboard operation
tvm copied to clipboard

Added macro generation in MLF export

Open fPecc opened this issue 2 years ago • 3 comments

For description see this forum topic.

Tagged reviewers: @areusch (don't know who else can review microTVM-related code)

fPecc avatar Sep 15 '22 10:09 fPecc

cc @Mousius @ashutosh-arm @grant-arm @gromero

leandron avatar Sep 15 '22 12:09 leandron

@fPecc from what I understood from reading your Discuss post, this is a non-breaking change, right?

Apart from that, I think the problem is quite restrict and it could be summarised/discussed in the PR, rather than in a separate location, but that's just a minor suggestion.

leandron avatar Sep 15 '22 16:09 leandron

Thanks for the feedback @areusch . Indeed, it shouldn't break, but there are still some tests that are not passing, so I am trying to fix that locally before continuing and commiting again.

fPecc avatar Sep 16 '22 06:09 fPecc

@Mousius could you take another look here?

@fPecc do you mind looking at the test failures? i think there are a few that need to get updated

areusch avatar Oct 17 '22 15:10 areusch

@fPecc Friendly reminder about this PR.

mehrdadh avatar Nov 08 '22 17:11 mehrdadh

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • Built docs for commit fa163033e0b27b59ea69f84219a8c7c6fb17a1f4 can be found here.

Generated by tvm-bot

tvm-bot avatar Nov 22 '22 17:11 tvm-bot

@mehrdadh sorry for the delay, there it is, all tests fixed.

fPecc avatar Nov 22 '22 17:11 fPecc

@fPecc there's some new conflicts, can you rebase and push again? might also fix CI 😸

Mousius avatar Nov 24 '22 13:11 Mousius

Hi @Mousius ,

I did the rebase, but I noticed there are still tests failing in CPU MINIMAL. They seem to be related to the CRT, but I cant find a direct relation with this change

fPecc avatar Dec 06 '22 10:12 fPecc

@fPecc Are you sure you did a rebase, not a merge? I suspect git rebase -i main will fix the CRT tests.

guberti avatar Dec 06 '22 11:12 guberti

Thanks for working through this one @fPecc! This is an awesome improvement and it has now landed 👍

Mousius avatar Dec 07 '22 11:12 Mousius