tvm
tvm copied to clipboard
Added macro generation in MLF export
For description see this forum topic.
Tagged reviewers: @areusch (don't know who else can review microTVM-related code)
cc @Mousius @ashutosh-arm @grant-arm @gromero
@fPecc from what I understood from reading your Discuss post, this is a non-breaking change, right?
Apart from that, I think the problem is quite restrict and it could be summarised/discussed in the PR, rather than in a separate location, but that's just a minor suggestion.
Thanks for the feedback @areusch . Indeed, it shouldn't break, but there are still some tests that are not passing, so I am trying to fix that locally before continuing and commiting again.
@Mousius could you take another look here?
@fPecc do you mind looking at the test failures? i think there are a few that need to get updated
@fPecc Friendly reminder about this PR.
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
- Built docs for commit fa163033e0b27b59ea69f84219a8c7c6fb17a1f4 can be found here.
Generated by tvm-bot
@mehrdadh sorry for the delay, there it is, all tests fixed.
@fPecc there's some new conflicts, can you rebase and push again? might also fix CI 😸
Hi @Mousius ,
I did the rebase, but I noticed there are still tests failing in CPU MINIMAL. They seem to be related to the CRT, but I cant find a direct relation with this change
@fPecc Are you sure you did a rebase, not a merge? I suspect git rebase -i main
will fix the CRT tests.
Thanks for working through this one @fPecc! This is an awesome improvement and it has now landed 👍