Kilosort icon indicating copy to clipboard operation
Kilosort copied to clipboard

nt0 is hard-coded

Open WeissShahaf opened this issue 3 years ago • 4 comments

Hello, I've been experimenting with increasing the sample window nt0 to =81 in kilosort3 (but this issue probably exists in kilosort2+), as my spikes are very long. unfortunately, I've had to recursively change many lines in the code to do that, as the 61 value is assumed at various points in the code.

not sure I got it all.

perhaps you can fix this more easily than me.

thanks

WeissShahaf avatar May 18 '21 08:05 WeissShahaf

Were you able to get the code working for nt0 > 61 @WeissShahaf? I changed all the hardcoded entries, but I'm getting CUDA errors. So, there may be aspects of the CUDA code that do not allow this.

JonathanAMichaels avatar Mar 31 '22 13:03 JonathanAMichaels

81 worked for me. but i did have to change alot of code

WeissShahaf avatar Mar 31 '22 20:03 WeissShahaf

I changed all locations where a "61" was hard-coded to ops.nt0, but these were only a few cases. Do you remember what else you had to change?

JonathanAMichaels avatar Apr 01 '22 14:04 JonathanAMichaels

unfortunately no. sorry. i quit using kilosort since, maybe will return one day

WeissShahaf avatar Apr 01 '22 14:04 WeissShahaf

@WeissShahaf do you still have that code lying around anywhere that you could send for me to look at? It seems that nt0 > 64 breaks mexGetSpikes2.cu

JonathanAMichaels avatar Jan 06 '23 22:01 JonathanAMichaels

I used a value of 81 specifically.

Shahaf Weiss, PhD

Max Planck Institute for Brain Research

NSK - Laurent department Max-von-Laue-Str. 4 60438 Frankfurt am Main, Germany www.brain.mpg.de

@.***

@.***

Tel:+49 17657814689

On Fri, Jan 6, 2023, 23:45 Jonathan A Michaels @.***> wrote:

@WeissShahaf https://github.com/WeissShahaf do you still have that code lying around anywhere that you could send for me to look at? It seems that nt0 > 64 breaks mexGetSpikes2.cu

— Reply to this email directly, view it on GitHub https://github.com/MouseLand/Kilosort/issues/401#issuecomment-1374225813, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK4J42D5KQXGUNF5BUPPZLTWRCOBRANCNFSM45CBUK4Q . You are receiving this because you were mentioned.Message ID: @.***>

WeissShahaf avatar Jan 07 '23 02:01 WeissShahaf