Moritz Kern
Moritz Kern
Hey, thanks for your detailed report. If I understand correctly this issue seems to be related to the name used for the variable/parameter producing unwanted behavior. This needs some investigation,...
you've pointed to line: https://github.com/NeuralEnsemble/elephant/blob/6ed3cb3089783035885e2fbec1fff535df7369cd/elephant/cell_assembly_detection.py#L363 another change to alpha seems to occur here: https://github.com/NeuralEnsemble/elephant/blob/6ed3cb3089783035885e2fbec1fff535df7369cd/elephant/cell_assembly_detection.py#L255 I suggest creating a validation test based on the original MATLAB implementation as a regression test....
Hi @jonahpearl , thanks for reporting this issue. PR #494 implements your solution by adding an install option: - development `pip install -e . --install-option='--no-compile' ` - install `pip install...
Thanks for reporting this. I get the same error. We will look into this, currently `elephant.statistics.instantaneous_rate` is undergoing changes with PR #453 in relation to #374.
Hey @sanjayankur31 , I've created a bugfix in PR #500 , please let me know if this solves the issue.
Hi @TRuikes , thank you for your persistent and steady work on this project to contribute to elephant. Since I am taking over this PR, I am unfortunately not familiar...
Hi @TRuikes , To keep the whole thing neatly organized, it seems to make sense to merge this as one PR. So I suggest to continue on this after september,...
I agree, the current state of this structure leaves room for improvement. Thanks for pointing this out. #### `sta.py` It seems the module `sta.py` originally contained only the `spike_triggered_average` function,...
This PR seems to be related to @ojoenlanuca s project. Link: https://github.com/ojoenlanuca/online_elephant
On a general note, how about creating a subpackage for all online measures ? e.g. : ``` elephant ├── online │ ├── __init__.py │ ├── mean_online.py │ ├── variance_online.py │...