MorenoProg
MorenoProg
## Planning Sender Silent Payment Support in Electrum I'm currently working on implementing sender-side silent payments in Electrum (as described in [BIP-352](https://github.com/bitcoin/bips/blob/master/bip-0352.mediawiki)). In doing so, I've come across several points...
I have been working hard on this issue and came to conclusive answers in the meantime: **Scope**: Silent Payments are currently limited to single-sig standard wallets with a BIP32 keystore....
Submitted PR #9900, looking forward to feedback!
@accumulator Yes thanks! I completely missed that bip21 had specifications for bip352. I addressed this in commit [b1d4144](https://github.com/spesmilo/electrum/pull/9900/commits/b1d41447ebf8917c2e71da2358535b01029438ed). It was more complicated than I thought, especially dealing with the absence...
@accumulator Oh.. yes, this is very likely because remove_silent_payment_address is called with txo.address as argument, which of course is None when there is a non-address scriptpubkey. Then the assertion makes...
> Have you considered OpenAlias resolving to a silent payment address? This would seem like an ideal combination.. > > https://github.com/MorenoProg/electrum/blob/1fc7ee5861d25c687400c88247a86e4c3ec5bc46/electrum/payment_identifier.py#L345-L358 I looked into it. Do you think the silent...
@accumulator I added openalias recognizing sp_addresses in [0c5e83d](https://github.com/spesmilo/electrum/pull/9900/commits/0c5e83d3af7a8a69ed32ad28ab6b923886950a57). It was almost nothing to change, which makes me think I missed something. I tested it by mocking the call to the...
There are still two design points where feedback is appreciated: 1. Password prompt: Since creating a silent payment requires access to the input private keys, the user is currently prompted...
@macgyver13 Thanks for testing. I am using a slightly modified version of the test vectors, in which the mapping of `sp_address` -> `taproot_outputs` is preserved. Also, I cleaned the [test...
> > Yes, that would be better. The current branch immediately signs the transaction as soon as the dialog is opened, which is different behavior than normal payments, and might...