MoonE

Better types in examples

5

This adds a lot of types, but also includes some code improvements. - wms-custom-proj did some unnecessary steps when converting between projections - The Edit button to edit on codesandbox...

Error when disposing WebGLVector layer after removing it from map

5

**Describe the bug** `ol/renderer/webgl/Layer` deletes its helper when it is removed from the map, but `ol/renderer/webgl/WebGLVector` does not clear its buffers. https://github.com/openlayers/openlayers/blob/bd895875240b61e70a0168b3311c9888b40868b8/src/ol/renderer/webgl/Layer.js#L70-L73 **To Reproduce** Steps to reproduce the behavior: 1....

Modify interaction adds points when drawing a new feature with Snap active

1

**Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: 1. Go to https://deploy-preview-16620--ol-site.netlify.app/en/latest/examples/snap-custom-segmenter.html 2. Draw one LineString 3. Draw...

Fix decimal column type detection for import

1

### Description First number of decimal type is all digits, second number is the number of decimals. To check if the type should be larger the number of digits before...

Search validate ints

1

Fixes partially #18542, need more changes in 6.0.0 I converted the tests from https://regexr.com/7h1ci and https://regexr.com/7h1eq to node/js tests. Not quite sure if I'm doing the exporting/importing of the functions...

Snap interaction not working correctly with Circles in GeometryCollection

4

**Describe the bug** These `getType` calls will return 'GeometryCollection', but the actual Geometry type is needed. https://github.com/openlayers/openlayers/blob/1d25288271b15b6350cf0d22d9f621d85d0a1342/src/ol/interaction/Snap.js#L815-L815 https://github.com/openlayers/openlayers/blob/1d25288271b15b6350cf0d22d9f621d85d0a1342/src/ol/interaction/Snap.js#L838-L838 https://github.com/openlayers/openlayers/blob/1d25288271b15b6350cf0d22d9f621d85d0a1342/src/ol/interaction/Snap.js#L864-L864 Also with custom segmenters we can't assume the geometry type for...

Snap intersection wrong when user projection is different from view projection

1

https://github.com/openlayers/openlayers/pull/17078#issuecomment-3311778296 So far the snap interaction uses the view and user projection only when segmenting circle geometries: https://github.com/openlayers/openlayers/blob/1e1c628848f49ce6881b803f96a947f89da8df1e/src/ol/interaction/Snap.js#L106-L112 Intersections may be wrong because of this: Should the Snap interaction track...

Fixes #634

Build insert statement with context's quote style

1

Fixes #630

Fixes #607 _ and $ are also non-separator characters.