phpmyadmin
phpmyadmin copied to clipboard
Fix decimal column type detection for import
Description
First number of decimal type is all digits, second number is the number of decimals. To check if the type should be larger the number of digits before the decimal point and after the decimal point need to be compared.
Fixes #19964
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.67%. Comparing base (5ec6b2f) to head (a447dc8).
:warning: Report is 29 commits behind head on QA_5_2.
Additional details and impacted files
@@ Coverage Diff @@
## QA_5_2 #19966 +/- ##
============================================
- Coverage 49.09% 48.67% -0.43%
- Complexity 17128 17131 +3
============================================
Files 607 607
Lines 72429 72435 +6
============================================
- Hits 35560 35255 -305
- Misses 36869 37180 +311
| Flag | Coverage Δ | |
|---|---|---|
| recode-extension | 49.53% <100.00%> (-0.61%) |
:arrow_down: |
| unit-7.2-ubuntu-latest | 49.03% <100.00%> (?) |
|
| unit-7.3-ubuntu-latest | ? |
|
| unit-8.2-ubuntu-latest | 49.42% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.