James McMahon comments

Results 32 comments of


                                            James McMahon

trafficstars

`create_age_groups` with bins of custom lengths

@r6lm This is a great idea and something we'd like to see taken forward. Do you have a suggested implementation? I like the idea of an `age_breaks` parameter that would...

Percent class for working with percentages

This was agreed to take forward as a PR

Guidance and recommendations for the use of {dbplyr}

I've done a quick draft based on a talk I did to the Gyle Code Club ages ago. I'll open a draft PR on this repo so others can see...

Guidance and recommendations for the use of {dbplyr}

PR opened, see #64

Script template changes and update metadata addin

I've just resolved conflicts again so I think this PR is as cleaned up as it can be. I guess it's now just on hold until the `git2r` issue is...

Upcoming lintr update will break `lint_xxx()`

This is now broken

Fix typos and mistakes and improve grammar

> :wave: @Moohan is any help needed, for instance with the Git aspects of selecting part of the changes? @maelle Thanks, nope I'm happy to look over the comments and...

Fix typos and mistakes and improve grammar

@mpadge - apologies for the long delay. I think that's my changes pruned down per your request, and it all properly rebased onto the current version of main.

Added percent functions.

> I also like the idea of users being able to create percent vectors using numbers representing literal percentages. We could have for example a function called `percent` or `create_percent`...

Added percent functions.

> > > I also like the idea of users being able to create percent vectors using numbers representing literal percentages. We could have for example a function called `percent`...