dev_guide icon indicating copy to clipboard operation
dev_guide copied to clipboard

Fix typos and mistakes and improve grammar

Open Moohan opened this issue 1 year ago • 4 comments

Moohan avatar Mar 03 '25 16:03 Moohan

Thanks @Moohan for your contribution, which we both encourage and appreciate. In this case, however, the PR includes too many changes for us to include straight off. A few of your suggestions and typo-fixes are good and helpful, but many of your suggestions are stylistic, and some go against our general style.

Feel free to retain your own record of all changes included here, but in the meantime could you please reduce the PR to the following reduced set of changes on line numbers:

  • 25
  • 64
  • 68
  • 80
  • 171
  • 216
  • 265 - a very important catch, thank you!
  • 269 - same!
  • 296
  • 297
  • 316
  • 318
  • 364
  • 370, 372, 373, but please re-insert line breaks after end of each sentence
  • 391
  • 397
  • 418

Thanks again for your contribution, which we'll definitely include once we're all in agreement here. Also note for future reference that no change is too small, and it is generally much easier for us to respond to smaller pull requests than ones of this size. Once we've reduced this one, you should feel free to suggest any additional changes via separate PRs.

mpadge avatar Mar 06 '25 11:03 mpadge

:wave: @Moohan is any help needed, for instance with the Git aspects of selecting part of the changes?

maelle avatar Mar 13 '25 12:03 maelle

:wave: @Moohan is any help needed, for instance with the Git aspects of selecting part of the changes?

@maelle Thanks, nope I'm happy to look over the comments and make changes :smile: . I'm away this week, I'll get back to this at some point next week hopefully!

Moohan avatar Mar 13 '25 16:03 Moohan

Thank you!!

maelle avatar Mar 14 '25 06:03 maelle

@mpadge - apologies for the long delay. I think that's my changes pruned down per your request, and it all properly rebased onto the current version of main.

Moohan avatar Jun 25 '25 09:06 Moohan

Thanks so much! I added a news item via your other PR.

maelle avatar Jul 01 '25 11:07 maelle