xavier chang comments

Results 697 comments of


                                            xavier chang

Fix enabling vgpu node lock

Hi, please squash it to one commit and sign off your commit: )

Feature/allow helm config overrides

/lgtm

Network Topology Aware Plugin

What's the difference between this and https://github.com/kubernetes-sigs/scheduler-plugins/tree/master/pkg/networkaware？

> > [https://github.com/kubernetes-sigs/scheduler-plugins/tree/master/pkg/networkaware？](https://github.com/kubernetes-sigs/scheduler-plugins/tree/master/pkg/networkaware%EF%BC%9F) > > I think it is a lite one of that plugin, just consider several physical topology, such as idc, rock, switch, and depend on those labels...

Network Topology Aware Plugin

It's a great feature and we ca > > Moreover, the current implementation of this plugin resembles a greedy algorithm, which aims to find the optimal node for each task....

Network Topology Aware Plugin

The best way is to use dynamic programming algorithm, but this needs a new design, which may beyond the scope of the issue, v.1.10 is about to release, so this...

Make sure volcano schduler cache synced before first scheduling by waiting for handlers sync.

Please rebase your pr: )

Make sure volcano schduler cache synced before first scheduling by waiting for handlers sync.

Does volcano controller also need catch this?

feat: add podgroup unenqueueable condition type and un-enqueueable reason

Hi, please update code geneate.