volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Fix enabling vgpu node lock

Open coldzerofear opened this issue 1 year ago • 9 comments

The current vgpu node lock plugin is not actually enabled, It needs to be enabled to prevent parallel device allocation errors

coldzerofear avatar Feb 26 '24 04:02 coldzerofear

Welcome @coldzerofear!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar Feb 26 '24 04:02 volcano-sh-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign shinytang6 You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Feb 26 '24 04:02 volcano-sh-bot

/assign @shinytang6

coldzerofear avatar Feb 26 '24 04:02 coldzerofear

cc @archlitchi Please take a look.

Monokaix avatar Mar 07 '24 09:03 Monokaix

Please sign off your commit: )

Monokaix avatar Mar 07 '24 09:03 Monokaix

Please note that "Node lock" conflicts with gang-scheduling in this version, if @coldzerofear encountered any device mis-allocation, please let me know.

archlitchi avatar Mar 07 '24 10:03 archlitchi

/ok-to-test

Monokaix avatar Apr 07 '24 12:04 Monokaix

Hi, please squash it to one commit and sign off your commit: )

Monokaix avatar May 08 '24 03:05 Monokaix

@coldzerofear: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar May 18 '24 06:05 volcano-sh-bot