MIRP icon indicating copy to clipboard operation
MIRP copied to clipboard

Add separate finding of include paths in CMake for each dependency library.

Open multiplemonomials opened this issue 3 years ago • 6 comments

This fixes the error I was getting:

CMake Error in mirp/CMakeLists.txt:
  Imported target "mirp_imported_mpfr" includes non-existent path
    "/usr/lib/include"
  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:
  * The path was deleted, renamed, or moved to another location.
  * An install or uninstall procedure did not complete successfully.
  * The installation package was faulty and references files it does not
  provide.

It's caused by the build system assuming that all headers are at location ../include relative to their respective library, which isn't always true.

I also bumped the version number to 1.0.2 so that dependers can ask for the updated version.

multiplemonomials avatar Feb 27 '21 02:02 multiplemonomials

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ca4d36c). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage          ?   86.88%           
=========================================
  Files             ?       23           
  Lines             ?     1525           
  Branches          ?        0           
=========================================
  Hits              ?     1325           
  Misses            ?      200           
  Partials          ?        0           

codecov[bot] avatar Feb 27 '21 02:02 codecov[bot]

@bennybp any way you could take a look at this? We are using MIRP on the QUICK project and this is causing us some issues integrating it.

multiplemonomials avatar Mar 26 '21 05:03 multiplemonomials

I think this looks reasonable. I see you also changed the version. Will you need a new tag/release?

I can add the tag, but probably can't do the full (compiled) releases like I did a few years ago.

bennybp avatar Mar 26 '21 21:03 bennybp

It's up to you I guess. Having a source release should be fine though.

multiplemonomials avatar Mar 26 '21 21:03 multiplemonomials

@bennybp Were you ever going to make that release?

multiplemonomials avatar Nov 16 '21 03:11 multiplemonomials

@bennybp bump^

multiplemonomials avatar Jun 24 '22 16:06 multiplemonomials