MohitMaliFtechiz
MohitMaliFtechiz
hi @kelson42 and @julianharty , We are downloading TestZim file in custom by using Fetch Library that why its included on cusotm.
hi @kelson42 , Yes in custom app we are downloading zim file initial on a first run.
> How works this PR? > > * Codefactor is red > * Does it systematically check code against Kotlin 1.7.0? > * Does it makes the CI red if...
> I don't know if this is possible to do better, but this is not really user friendly. hi @kelson42 do you have any idea what addition i can do...
hi @gouri-panda , is this PR is ready for review ?
hi @gouri-panda , coverage reporting is failing on both can you please take a look at it.
Hi @gouri-panda , Test failing reason is you forgot to paas ```drawer id``` and ```gravity``` to ```openDrawer()``` Method. https://github.com/kiwix/kiwix-android/blob/bb661551134b38de3a6ce712a2c6dfe22c42f168/app/src/androidTest/java/org/kiwix/kiwixmobile/main/TopLevelDestinationRobot.kt#L74 As you change parameters here. https://github.com/kiwix/kiwix-android/blob/bb661551134b38de3a6ce712a2c6dfe22c42f168/app/src/androidTest/java/org/kiwix/kiwixmobile/utils/StandardActions.java#L46
hi @gouri-panda , There were 19 test which were executed before this implementation now only 14 test are running , some of test like TopLevelDestination and other are not executing...
> @MohitMaliFtechiz Some network tests are skipping because in our CI no cellular provider there. hi @gouri-panda , All test which are extended by ```BaseActivityTest``` is not running so this...
hi @gouri-panda please fix the coverage reporting , i think you are still working on this please mark it as draft.