onetl
onetl copied to clipboard
[DOP-15749] - separate ReadOptions into ReadOptions and SQLOptions
trafficstars
Change Summary
ReadOptionsandSQLOptionshave been separated for JDBC connections.SQLOptionsis now required for.sqlmethod calls- Add following tests and documentation
Related issue number
Checklist
- [x] Commit message and PR title is comprehensive
- [x] Keep the change as small as possible
- [x] Unit and integration tests for the changes exist
- [ ] Tests pass on CI and coverage does not decrease
- [x] Documentation reflects the changes where applicable
- [x]
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change (see CONTRIBUTING.rst for details.) - [x] My PR is ready to review.
Codecov Report
Attention: Patch coverage is 97.36842% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 94.46%. Comparing base (
09973cf) to head (265fa6d).
| Files | Patch % | Lines |
|---|---|---|
| ...onnection/db_connection/jdbc_connection/options.py | 96.15% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #272 +/- ##
===========================================
- Coverage 94.48% 94.46% -0.02%
===========================================
Files 204 204
Lines 8012 8047 +35
Branches 1405 1409 +4
===========================================
+ Hits 7570 7602 +32
- Misses 319 320 +1
- Partials 123 125 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
В unit тестах есть test_jdbc_read_options_default. Нужно сделать такой же для SQLOptions.