Marius Kohmann

Results 18 comments of Marius Kohmann

You are correct, detekt hint is an extension of detekt that adds a new ruleset. Unfortunately, i am not able to create a new extension for Danger to make this...

Should i include more than public methods? Hidden, non overridden methods should possibly also be included.

https://softwareengineering.stackexchange.com/questions/244773/is-method-overriding-always-a-violation-of-liskov-substitution-principle

update square rectangle sample with a square with only side - length.

@ntindle that is a good idea, and thanks for looking into the project! A readme/documentation defining the specifications should be created. As a beginning i think the project readme can...

Do analysis on all methods of a class. (Or methods that does not is within class). Exists in IntelliJ for Java.

Also exists in PMD for Java.

This should be implemented before the final artifact is evaluated. Shows that i took the feedback and did something with it.

Should possibly not count `override` variables, as they implicitly is used by the parent class?

Sure, will do! But be aware that the list of issues will be long, and contain many false-positives. Using it without the github integration will defeat much of its purpose,...