Steffen Roßkamp
Steffen Roßkamp
Resolved conflicts. Could you please give me a heads up why my changes might remove coverage [here](https://app.codecov.io/gh/doctrine-extensions/DoctrineExtensions/compare/2171/changes#D1L120) @phansys? Or should I ignore that?
@phansys Thank you for your answer. I can't see any conflicts, though.
Nope, I get this 
I get conflicts when I try to rebase, though. Still weird, but I will do this now
OK done @phansys. Just wanted to ask if you could also check that I did not reintroduce some of the old issues?
@phansys I was just referring to the issues you pointed out in your reviews. To make sure I did not reintroduce one of them while rebasing.
I'm open to that @franmomu of course. But it might be out of scope for this PR as it would need changes all over DoctrineExtensions. So maybe it warrants a...
@rotdrop I remember using `IdentifierFlattener` during initial development of this, which did not work at the time, but that may have change since then ... @phansys Could you please have...
> I guess you should add the new `$flatten` argument in the existing calls to `WrapperInterface::getIdentifier()`. The calls were not the problem, but the classes implementing the interface, only adding...
@phansys And another error which I think is unrelated. My guess would it to be a hiccup on GitHubs end. Can you please re-run the failed jobs as I can't...