Steffen Roßkamp
Steffen Roßkamp
Would you consider to also add this in the PR as it is also PHP 8 related? ```log Return type of Khill\Lavacharts\Support\Contracts\Jsonable::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or...
> controller methods should be marked as used when a route is defined for them I'd see it as a bonus if they're only be marked as used if that...
Good points indeed. 😊 But maybe still viable as an option which is off by default
I just wanted to throw the optimization [``AutowireRequiredMethodsPass``](https://symfony.com/doc/current/service_container/autowiring.html#autowiring-other-methods-e-g-setters) into the mix, as it doesn't work with [tagging](https://symfony.com/doc/current/reference/dic_tags.html#dic-tags-monolog) because the ``LoggerChannelPass`` is executed earlier.
Rebased and fixed PHP and XML code style
Well, finally adopted the changed test namespaces. @phansys Could you give me a heads up, where this breaks BC, please? Maybe this can be changed
Resolved conflicts and code style @phansys Could you please verify this no longer breaks BC?
Resolved all requests
@phansys Hopefully I catched all missing type hints and imports. The PHPStan error seems to be unrelated to this PR
You are right of course, doesn't make sense to not mention it 😅