Mirv

Results 8 comments of Mirv

So I've been poking through several things ... 7 of 9 javascript gems I checked stated about the same theme ... > There was a vanilla JS version, but it...

Yea - I submitted a PR to divide out some of the #add_fields responsibility and make the path moving forward easier, as well as some minor cleanup earlier this week...

@danbob - I grabbed your version & hit it with es-linter - it probably mucked up some stuff but I also cleaned up a few other things and ran my...

That looks really good - I was just copy & pasting what we needed from jquery lib! Also - sorry! I saw a bug in there when I got up...

@danbob I was playing with this [line 74](https://github.com/danbob/cocoon/blob/720087383750186d28e3d0fca35aad1e7c227f94/app/assets/javascripts/cocoon.es6.js#L74) for awhile too, in an attempt to ... - Use a descriptive name in place of a rather long conditional - Encapsulate...

> not a ternary conditional but rather a regex non-capturing group with alternation Just further showing that line isn't easily deciphered :) Maybe just name the variable `associationRegex` to prep...

I've been playing with https://www.3drudder.com/

I'm not super great with using your gem yet...but you did add this in right? ``` { :class => "nav nav-tabs" }, :active_class => "active" do |tab| %> `` The...