Gaël Robin

Results 97 comments of Gaël Robin

## Scope a solution To do this, we can change [this line](https://github.com/wp-media/wp-rocket/blob/ea129493e87d730b4b3d3709e09c041a3c7f6beb/inc/admin/upgrader.php#L107) & [this line](https://github.com/wp-media/wp-rocket/blob/ea129493e87d730b4b3d3709e09c041a3c7f6beb/inc/admin/upgrader.php#L109) to be `1` instead of `0`. So we'll ensure to get it enable for new...

## Scope a solution ### Root Cause Analysis The issue is in the `preconnect()` method in `GoogleFonts/Subscriber.php`. Currently, it always adds the `fonts.gstatic.com` preconnect when Google Fonts optimization is enabled,...

@jeawhanlee It wouldn't have. I've changed the full grooming :)

@jeawhanlee , I don't know how did you figure that out, but you are right, after looking at it from another angle, that would probably not work properly. 🤔 After...

Hello hello @jeawhanlee , I'm not sure the option 1 would work with the scenario 2 & 3 from the issue. **Scenario 2: Only Google Fonts combine enabled (no self-hosting)...

After jumping in a call with @jeawhanlee , We confirm that the Option 1 mentioned: ### Option 1 In `WP_Rocket\Engine\Media\Fonts\Frontend\Controller` - Update [this](https://github.com/wp-media/wp-rocket/blob/ef97b56ce2f39a38de7316075e34c1508a3e0018/inc/Engine/Media/Fonts/Frontend/Controller.php#L402) method to check matching `gstatic` or `googleapis`...

### Scope a solution ⚠ This has nothing to do with WP Rocket in terms of codebase. But more likely the rocket-scripts. In the `BeaconPreloadFonts` class, we currently have a...

It has nothing to do with WP Rocket itself, but more with beacon within `rocket-scripts` ### Scope a solution The issue involved external font URLs defined within `style` tags not...

Umm, @jeawhanlee, You can't do it on the PHP side, as you don't get everything saved in the DB as it should. > Another note: Some external domains are not...

So @jeawhanlee if I understand well your feedback, here is the approach: 1. **Add a filter in PreconnectExternalDomains Frontend** Controller after the conditional check and before the return statement 2....