Gaël Robin
Gaël Robin
So based on our conversation yesterday, I guess we have to merge this PR and prepare another issue to enhance it, @wordpressfan as you had the idea for the enhancement,...
> How it works with video + preview image?: “To investgiate to understand, not necessarily to fix” Insert a video in a page/post and enable the preview image option on...
> Pages in a background tab? What if we open the page with Ctrl+Click and don’t visualize the page? What happens to the beacon script? The beacon script seems to...
@MathieuLamiot , I've added integrations tests to the PR and modified the User documentation. :)
@Mai-Saad, The issue was imploding an empty array gives an empty string. And it would match everything in the `preg_match` [here](https://github.com/wp-media/wp-rocket/blob/a41b8b6e307aa878225bcc3a0fec941fb544d14a/inc/Engine/Optimization/RUCSS/Controller/UsedCSS.php#L836). It's been fixed now as I've added a check...
Umm, For the 1st point, I've noticed it, but as it is on trunk, I supposed it was normal. For the 2nd point, it's fixed in the latest commit.
Seems okay to me.
Here is the new PR to modify the thresholds values: https://github.com/wp-media/wp-rocket/pull/6593
## Reproduce the problem Well, there isn't a proper way to reproduce the issue, however, we could hard code a string in `$job_details['code']` here https://github.com/wp-media/wp-rocket/blob/2b2243e08aecf0d7618179106c2a133749762e47/inc/Engine/Optimization/RUCSS/Strategy/Strategies/DefaultProcess.php#L108 This would ensure to get...
I've modified the grooming accordingly to the feedback from @Tabrisrp