Benjamin Ling comments

Results 12 comments of


                                            Benjamin Ling

Allow --keepfuncs and --splitfuncs to be use alongside a profile data

@tlively Can you see if this is a suitable improvement that we can include for wasm-split? If so, do we wish to expand it to the `--split-funcs` flag as well?

Allow --keepfuncs and --splitfuncs to be use alongside a profile data

Thanks! I've expanded this usage to the `--split-funcs` flag as well. The functions in `--split-funcs` will supersede the other split options and show a warning if it contradicts with the...

Allow --keepfuncs and --splitfuncs to be use alongside a profile data

@tlively Thanks for your review and the comments! Could you help me see if there's anything else I should add in this PR?

Allow --keepfuncs and --splitfuncs to be use alongside a profile data

@tlively Fixed comment and the newline at the eof.

Allow --keepfuncs and --splitfuncs to be use alongside a profile data

@tlively sorry for the delayed response. I'm still interested to get this in if possible. I'll need some help to trigger the CI so that I can look at the...

Allow --keepfuncs and --splitfuncs to be use alongside a profile data

I've attempted to fix the linting and the test failures. Please help to trigger the CI again 🙏

Allow --keepfuncs and --splitfuncs to be use alongside a profile data

@tlively @kripken 1 last trigger I hope, before we can land this PR

Print out callgraph of a specific entry point

> It looks like we don't have a test for this pass. If you want to extend it then I suggest we first land a PR that adds a test...

cross-pthread creation and destruction of WebGPU objects

>So if it turns out not to be that difficult to proxy these, I'd be all for providing it (behind some build flag). @kainino0x May I check if this is...

`load_secondary_module_status` not recognized as a global object with emscripten's MAIN_MODULE flag

Hi @brendandahl, I'm tagging you here because I saw that you added `load_secondary_module_status` in https://github.com/WebAssembly/binaryen/pull/5431. Should this be fixed by prepending this variable with a '%'?