Louis Lagrange comments

Results 51 comments of


Louis Lagrange

Cannot find module "SwiftyStoreKit" in Pods

I have not tried other releases but using this commit works great https://github.com/bizz84/SwiftyStoreKit/commit/e518abea746857ea2b3348ade9e9143d88d7e431

docker demo

Thanks! Can you maybe add this to the example repo instead of the library's?

Unittests on travis are failing because of web-push-testing-service

Yes I'm aware and this is a bit of pain to debug, I welcome help here :)

Uncaught RuntimeException thrown when the publicKey(p256dh) has - at the end. e.g BGzoP5QD6aKTKGhmQ9pwIl0pLYNdxMHP3MmWaukujsXtweN9BQuIPVihjpf-

Do you have some example of subscription+vapid?

PHP Fatal error: Uncaught InvalidArgumentException: Unable to load the key. in /vendor/web-token/jwt-key-mgmt/KeyConverter/KeyConverter.php:182

Can you try on v6.0.1 please ?

Firefox for Android doesn't deliver every push notifications

Hi, thanks for your feedback. :) The value indicated [here](https://github.com/web-push-libs/web-push-php#how-can-i-disable-or-customize-automatic-padding) might be outdated. Maybe try with setAutomaticPadding(X), where X < 3052?

Firefox for Android doesn't deliver every push notifications

With hindsight, I don't think the length of automatic padding is wrong here. You would have received a [413 error](http://autopush.readthedocs.io/en/latest/http.html#errors). It looks like a sync problem through the GCM bridge...

Argument 1 passed to Point::create() must be an instance of BigInteger, instance of GMP given

Can you try on v6.0.1 please?

Dropped support for PHP 7.3

Hi @stephanvierkant, we now have integration tests running once again thanks to #330. Can you rebase please? Thanks

Drop support for EOL versions of PHP?

Yes