MinhLA1410

Results 10 comments of MinhLA1410

Hello @mkgrgis, thanks for your hard work. I have question about this description. Could you help me to answer them? > Add tests for correct arithmetical ordering I don't understand...

Thanks @mkgrgis ! So I understand that: - `Add tests for correct arithmetical ordering` just is related to the modification in https://github.com/mkgrgis/sqlite_fdw/blob/cbde7e860bd2a47c2cdee54256be789a13fbb7c0/expected/16.0/extra/float8.out#L2029 - About the modification of `aggregates test` is...

> Yes, absolutely correct. Thanks @mkgrgis , > Add some inactive tests for NaN values, add detailed comments about current processing of NaN values, but no changes to current NaN...

I understand it. > because according ISO:SQL a value must be readable (SELECT), writeable (INSERT, UPDATE) and detectable or filtrable (WHERE = < >). > NaN is the same special...

@mkgrgis , > will https://github.com/pgspider/sqlite_fdw/commit/1db7f67501347ccecec093eb881ded5ccc0b4581 enough? It's OK. Thank you. > In PostgreSQL ±∞ values sorted before or after any usual numeric values according ISO:SQL, in SQLite infinity values with...

@mkgrgis , ``` sqlite> insert into "type_FLOAT_INF" values (10, '-Inf'); sqlite> insert into "type_FLOAT_INF" values (11, '+Infinity'); sqlite> select i,typeof(f) from "type_FLOAT_INF"; 1|real 2|real 3|real 4|real 5|real 6|real 7|real 10|text...

@mkgrgis Yes. I will leave the decision to @t-kataym

Hi @mkgrgis I tried to build rpm file from your spec. But it does not work. Could you please check again ``` error: parse error in expression error: ${HOME}/sqlite_fdw/rpm.spec:25: bad...

Hello @mkgrgis , To create rpm file, we have to define the specification of the source code location firstly. * If spec file processed source-code in %prep (download src, from...

@mkgrgis , Thank you for consider it. I also think you should use the latest sqlite_fdw source code to create another PR to fix the problems above. debbuild is mostly...