Mingwei Samuel

Results 192 comments of Mingwei Samuel

As far as I can tell these fields are no longer returned slash `gameQueueConfigId` is used now.

Here are the 106 keys for **challenges** I have found. This is for the new & undocumented `challenges` field in `match-v5.ParticipantDto` Edit: moved to gist to keep things in revisions:...

Updated list: https://gist.github.com/MingweiSamuel/d5f9dc40cc5a80a9255e488f27705c56 Total: 118 New values: ```json "completeSupportQuestInTime", "dodgeSkillShotsSmallWindow", "epicMonsterStolenWithoutSmite", "fasterSupportQuestCompletion", "kTurretsDestroyedBeforePlatesFall", "landSkillShotsEarlyGame", "multiTurretRiftHeraldCount", "quickCleanse", "quickFirstTurret", "quickSoloKills", "soloTurretsLategame", "threeWardsOneSweeperCount", ```

> Hey, are these values guaranteed to show up or are there some values that are sometimes let out? Some values are sometimes left out

~~I'm actually having trouble reproducing this right now. Does anyone have a summoner name to reproduce this issue? doesn't show up for https://lolchess.gg/profile/na/s%C3%A8tsuko or https://lolchess.gg/profile/na/d%C4%B1shsoap (top rated NA TFT players)~~...

Thanks for taking the lead on this @aPinat Logically the `queueTypes` for LoL vs TFT ought to be separate, but it seems they are very much mixed together internally as...

Same with: ``` JP1_273343663 JP1_267836848 JP1_267647303 JP1_268045590 ``` from #554

Ah right > Prior to patch 11.4, on Feb 18th, 2021, this field returned invalid championIds. We recommend determining the champion based on the championName field for matches played prior...

Example of how to use it: https://github.com/ChampionMains/Pyrobot/blob/5a89751bb1eebedbf61f9a9c9ff526f2feae9356/ChampionMains.Pyrobot.Infrastructure/Services/Reddit/EmojiService.cs#L38-L40 I wanted to support `sync` vs `async`, and also `byte[]` vs `inputstream`, so the actual implementation has a few layers. I also ended...