developer-relations icon indicating copy to clipboard operation
developer-relations copied to clipboard

[BUG] RANKED_TFT_DOUBLE_UP shows up in League-V4 response

Open bangingheads opened this issue 3 years ago • 7 comments

Bug Description
Players who are ranked in the new TFT Pairs game mode show as a response to League of Legends ranks.

This is part of the /lol/league/v4/entries/by-summoner/{encryptedSummonerId} response.

Problem Description
This is an unknown queue for League of Legends and can cause issues in processing ranks.

Expected Result
To show RANKED_TFT_PAIRS in TFT-League-V1

Actual Result
Shows response in League-V4

Developer Impact
An unknown queue is found which can cause some scripts to error out. It also does not contain tier & rank in the response so it does not follow the DTO specification.

bangingheads avatar Nov 18 '21 21:11 bangingheads

Still happening. Experiencing serious issues because of this in regards to rank

dan-dr avatar Jan 08 '22 11:01 dan-dr

good to know nothing changed during the holidays.

Querijn avatar Jan 08 '22 13:01 Querijn

Still happening even after the switch from MMR/points-based ranks to the Iron/.../Challenger system

molenzwiebel avatar Jun 14 '22 20:06 molenzwiebel

Said switch in TFT Set 7 marks the introduction a new queueId of 1160 and queueType RANKED_TFT_DOUBLE_UP instead of RANKED_TFT_PAIRS. Also: https://github.com/RiotGames/developer-relations/issues/574#issuecomment-1159847974

aPinat avatar Jun 20 '22 00:06 aPinat

+1 my app only has access to tft endpoints, so it can't get the rank of a user for queue RANKED_TFT_DOUBLE_UP

whyando avatar Jun 20 '22 11:06 whyando

~~I'm actually having trouble reproducing this right now. Does anyone have a summoner name to reproduce this issue? doesn't show up for https://lolchess.gg/profile/na/s%C3%A8tsuko or https://lolchess.gg/profile/na/d%C4%B1shsoap (top rated NA TFT players)~~

https://lolchess.gg/leaderboards?mode=doubleup&region=na

MingweiSamuel avatar Jun 21 '22 03:06 MingweiSamuel

@MingweiSamuel Those two don't have a Double Up rank, they only have their classic TFT ranks, try https://lolchess.gg/profile/euw/aatale or https://lolchess.gg/profile/na/jessixa as top rated Double Up players in EUW/NA.

aPinat avatar Jun 21 '22 12:06 aPinat

Is it going to be fixed?

GuillerLT avatar May 03 '23 08:05 GuillerLT

On our radar, will look into it!

tisbells avatar Jul 26 '23 15:07 tisbells

Hey, thanks for reporting this issue.

I added RANKED_TFT_DOUBLE_UP in the tft-league-v1 response.

To avoid breaking existing applications, I will keep league-v4 returning RANKED_TFT_DOUBLE_UP for one more week. After Sep/18 only tft-league-v1 will return RANKED_TFT_DOUBLE_UP queue.

lucasMesquitaBorges avatar Sep 11 '23 19:09 lucasMesquitaBorges

@lucasMesquitaBorges first of all, thank you very much for that change and the clear communication ^^. As this is more or less a "breaking change", I think it would be fair to announce that on Twitter to notify api consumers who were not subscribed to this GitHub issue

DarkIntaqt avatar Sep 11 '23 20:09 DarkIntaqt

Sure! We planned to make comms in other channels, I forgot to mention this in my previous comment.

Until we sync most of possible developers using the double up queue from league-v4 endpoint we'll keep it returning from both endpoints. The deadline of one week is removed.

As soon we have the new date I'll post here. (Will be announced in the other channels too).

lucasMesquitaBorges avatar Sep 12 '23 03:09 lucasMesquitaBorges

Hiya - We're giving everyone until October 3 to make any necessary changes before removing this from League-v4. https://twitter.com/RiotGamesDevRel/status/1701723426178650191

tisbells avatar Sep 13 '23 21:09 tisbells