Mike McCready

Results 2194 comments of Mike McCready

@ramykl Thank you for updating the PR! ~~For better readability, please mark the comments you consider as resolved using GitHub's [Resolving conversations](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#resolving-conversations) facility.~~ Edit: done There is a general problem...

@ramykl Check if https://pnpm.io/npmrc#manage-package-manager-versions meets your needs for pnpm. It is enabled by default. ![image](https://github.com/user-attachments/assets/7b07e40d-57ba-4288-a29e-c0785aeed8c5)

@ramykl Do you still want to propose this PR? If so, you would need to rebase / update it.

@ramykl 5 of the 6 failing checks are due to the PR coming from a fork which is not set up to record to Cypress Cloud. > You passed the...

@ramykl Are you planning to work on the failure mentioned in https://github.com/cypress-io/circleci-orb/pull/486#issuecomment-2766801258 ?

@ramykl Unless you plan to work on this PR again, I suggest to close it.

- Closing since this PR is stale. Apart from merging the master branch into the PR branch in March 2025, the last work done on this PR was in November...

This PR is outdated The [CI job](https://github.com/nodejs/corepack/blob/main/.github/workflows/ci.yml) runs on the following, corresponding to the latest GitHub runner cached version of each Node.js version: https://github.com/nodejs/corepack/blob/19e3c6861a8affdfd94d97edf495c21e591fe4e0/.github/workflows/ci.yml#L48-L52 and `engines` is set as follows:...

I suggest to close this PR as it is stale and it is unlikely for the current `engines` setting to be downgraded to `^20.0.0`. The current setting is: https://github.com/nodejs/corepack/blob/0b492c9c97e4b3d5e9a139eeedb931860127b470/package.json#L12-L14 This...

@kostiantynvoiku It looks like you may be using pnpm workspaces. Please note that there is no native support in the action for this (see https://github.com/cypress-io/github-action/issues/1144). You can check the example...