corepack icon indicating copy to clipboard operation
corepack copied to clipboard

Allow node v20+

Open emptyflask opened this issue 1 year ago • 4 comments

This was added in 9a1cb385bba9ade8e9fbf5517c2bdff60295f9ed when dropping support for node v19, but I can't see any reason why for instance node v20.5.0 should be excluded.

emptyflask avatar Aug 19 '24 19:08 emptyflask

Does it matter? I think it'd help if you explain your use case.

aduh95 avatar Aug 19 '24 21:08 aduh95

I have to work with some Ubuntu 20.04 servers that are stuck on node 20.5.1 for some reason. Corepack seems to be compatible with it, so it seems odd to arbitrarily require a specific minor release in the package.json

emptyflask avatar Aug 20 '24 04:08 emptyflask

It's not exactly arbitrary, Node.js 20.5.1 was a current release, and Node.js 20.10.0 was a LTS release. I would encourage you to upgrade, you're behind a few security releases.

If we're making changes, we should also remove changes to Node.js 21.x, and remove the CI job.

aduh95 avatar Aug 20 '24 08:08 aduh95

This PR is outdated

The CI job runs on the following, corresponding to the latest GitHub runner cached version of each Node.js version:

https://github.com/nodejs/corepack/blob/19e3c6861a8affdfd94d97edf495c21e591fe4e0/.github/workflows/ci.yml#L48-L52

and engines is set as follows:

https://github.com/nodejs/corepack/blob/19e3c6861a8affdfd94d97edf495c21e591fe4e0/package.json#L12-L14

MikeMcC399 avatar Mar 18 '25 11:03 MikeMcC399

I suggest to close this PR as it is stale and it is unlikely for the current engines setting to be downgraded to ^20.0.0.

The current setting is:

https://github.com/nodejs/corepack/blob/0b492c9c97e4b3d5e9a139eeedb931860127b470/package.json#L12-L14

This corresponds to the earliest LTS releases of Node.js 20 & 22.

https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md (first 20.x LTS was 20.9.0) https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md (first 22.x LTS was 22.11.0) https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V24.md (first 24.x release - hasn't reached LTS yet)

MikeMcC399 avatar Jul 23 '25 14:07 MikeMcC399