Michael Edgar
Michael Edgar
@vietj, I'm curious to get your thinking on these changes. I realize there needs to be a certain amount of caution with changes to these classes/methods.
> it looks good overall but there are a few things that need to be addressed Thanks, let me know what's needed when you have an opportunity. No rush from...
@vietj , now that #4468 is the path forward on this, should we just close this one?
Researching test failures
Hi @vietj , what led me to believe it was blocking were stack traces like the following. This is from version 4.1.7 in Quarkus 2.2.5, but I don't think it's...
Thanks, I'll test that out to confirm it.
@vietj , updating `listen` to run on a worker thread (from `bind`) was more obvious to me since it's already returning a `Future`. In order to alter `SSLHelper#validate` to run...
I've had some success with the changes to `SSLHelper` as they relate to `TCPServerBase`. It's take some re-factoring of the `TCPServerBase#listen` method to account for handling of shared servers, I'll...
I opened https://github.com/eclipse-vertx/vert.x/pull/4441 for this.
Hi @NandaBalakrishnan this will be in the next release. I'll likely have some time to get to it later this week or early next.