Execute SSLHelper.validate as blocking

[MikeEdgar]

trafficstars

Motivation:

Proposed to fix https://github.com/eclipse-vertx/vert.x/issues/4439

[MikeEdgar]

I think the use of CountDownLatch in TCPServerBase is also going to be a problem. I'm still looking into that.

[MikeEdgar]

@vietj, I'm curious to get your thinking on these changes. I realize there needs to be a certain amount of caution with changes to these classes/methods.

[vietj]

it looks good overall but there are a few things that need to be addressed

[MikeEdgar]

it looks good overall but there are a few things that need to be addressed

Thanks, let me know what's needed when you have an opportunity. No rush from my perspective.

[vietj]

I will actually reuse this in an general improvement of the SSLHelper because there are other SSLHelper related work that should be done.

• https://github.com/eclipse-vertx/vert.x/pull/4372
• https://github.com/eclipse-vertx/vert.x/issues/4452
• https://github.com/eclipse-vertx/vert.x/pull/4453

[vietj]

@MikeEdgar please have a look at https://github.com/eclipse-vertx/vert.x/pull/4468

[MikeEdgar]

@vietj , now that #4468 is the path forward on this, should we just close this one?

[vietj]

yes, I'll credit you in the orignal issue.