Michael Edgar

Results 220 comments of Michael Edgar

@johanhaleby, please consider accepting this patch.

Thanks for taking a look. I'll get this rebased ASAP.

> @MikeEdgar do you have the cycles to do it? @gsmet I'm on it :+1:

Re-based ... I still need to verify that the changes are good with for metaspace clearance, but at least `mvn verify` is passing for me locally :)

I am still working through the verification. It seems that there is something new occurring with Groovy 5 and possibly a different metaspace leak.

@johanhaleby, this PR is ready for review/merge from my perspective. As noted in a thread, the changes in `Groovy5JsonSlurperWorkarounds` also resolve a `StackOverflowException` observed due to the meta-class patching. The...

@andreas-eberle have you tried using an annotation on the REST method to provide the schema you're looking for? Something like this: ``` @APIResponseSchema(String.class) ```

That is probably reasonable, but I wonder does it universally apply for any `Multi` with a content-type of `text/event-stream` ?

@andreas-eberle I just am questioning whether a `Multi` always (or more often than not) should result in the response schema you're expecting rather than an array. I'm unsure myself.

Yes, we would need to scan multiple times, apply filters to each document at runtime (do filters apply to all or just one OpenAPI result?), etc. Another important thing to...