Aleksei Strizhak

Results 64 comments of Aleksei Strizhak

Hey @sandersn thanks for the review. Could you recommend an update for [package.json version](https://github.com/Mifrill/DefinitelyTyped/blob/129645c13623d5b5ab18b5a74649e72d8eb67863/types/jsonwebtoken/package.json#L4) in this particular case? As I see in [documentation](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#how-do-definitely-typed-package-versions-relate-to-versions-of-the-corresponding-library) that `@types packages always type packages of...

@peterblazejewicz the problem is `expiresIn` cannot be `undefined` when specified. See this test: https://github.com/Mifrill/DefinitelyTyped/blob/129645c13623d5b5ab18b5a74649e72d8eb67863/types/jsonwebtoken/jsonwebtoken-tests.ts#L57-L58 The optional `expiresIn` property, can be only a string or number, but cannot be undefined. This...

@jakebailey Thank you for the feedback 👍 I will make changes for v8 in the next PR shortly.

Hey @patmagee, @cjllanwarne just a gentle reminder, please have a look at this PR when you get a time 🙏

@jkusa yes, it is still an issue, because v1.0.0 cannot be used for the legacy ember version that is involved in this particular issue.

@jkusa > Are you invoking the component with angle brackets? I've tried both. For angle brackets I've used latest version of https://github.com/ember-polyfills/ember-angle-bracket-invocation-polyfill. > is there a feature you are looking...

I'm on version 1.6.4 and the import literally not working regardless of the unsafe path: - import isAbsoluteURL from 'axios/lib/helpers/isAbsoluteURL' - import isAbsoluteURL from 'axios/lib/helpers/isAbsoluteURL.js' - import isAbsoluteURL from 'axios/unsafe/helpers/isAbsoluteURL'...