Aleksei Strizhak

Results 64 comments of Aleksei Strizhak

> Is this better way? yeah, probably... Or this way: ```ruby class ApplicationSpider < Vessel::Cargo driver :ferrum, headless: false def self.settings @settings ||= super.merge(ApplicationSpider.settings) end end class ExampleCom < ApplicationSpider...

First of all i would to say Great Thanks! its incredible lib, i'm done cartwheels when i saw this in first time! I'd be very grateful if you adding docs...

Any plans on fixing this issue?

It looks like applyeble to `add` function too: ```JS moment("2021-04-30").add(1, 'month').toString(); // "Sun May 30 2021 00:00:00 GMT+0500" ``` should be `"Sun May 31 2021 00:00:00 GMT+0500"` I guess

any updates on that? As an alternative it also might be useful to add `total_pages` or `total_runs` as new property for endpoint response: https://github.com/ga4gh/workflow-execution-service-schemas/blob/c3b19854240c4fcbaf3483e22b19db0a918a7ee5/openapi/components/schemas/RunListResponse.yaml#L3-L11 or like it's done in TRS...

@denis-yuen > TRS uses HTTP headers for pagination links That's correct, but why WES is not? https://github.com/ga4gh/workflow-execution-service-schemas/blob/develop/openapi/components/schemas/RunRequest.yaml https://github.com/ga4gh/workflow-execution-service-schemas/blob/c3b19854240c4fcbaf3483e22b19db0a918a7ee5/openapi/paths/runs.yaml#L23-L30 Why it's using page_size and page_token query params instead of TRE format?...

@patmagee thanks for the review! > what you are trying to solve with the total_runs The total count required to implement "orthodox" pagination, by dividing the total count by page...

Hi @jimryan! Thank you for your contribution! Can you please merge/rebase PR with the updated master, let's see how CI goes

@route [appveyor](https://www.appveyor.com/) definitely supports windows, we can submit CI run for (let's try maybe). I did request access: ![Selection_757](https://user-images.githubusercontent.com/23525618/131255850-dc8e46d9-b359-4012-acf4-420cc8a16131.jpg)

Hi, @rogercampos can you please check out this PR: https://github.com/rubycdp/cuprite/pull/125? Is it solves your case and we can close this one?