Mikael Ek comments

Results 6 comments of


                                            Mikael Ek

Fixes to isArray, handled when input is `any`

@DeepDoge Would it be possible to make this handle readonly arrays as well? With the current implementation these tests fail. ```typescript doNotExecute(() => { const arrOrString = [] as readonly...

Improvment to `Array.isArray`

@mattpocock @DeepDoge @phenomnomnominal I have not been able to make it pass the final test. If you have any suggestions I'd be happy for the help.

Improvment to `Array.isArray`

I have been able to get either or of ```typescript doNotExecute(() => { function test(value: T) { type Unarray = T extends Array ? U : T; const inner =...

Improvment to `Array.isArray`

Thanks @DeepDoge for your answer. If @mattpocock agrees I could just remove that test and it would be ready from my side.

Improvment to `Array.isArray`

@mattpocock I removed the failing test based on [this comment](https://github.com/total-typescript/ts-reset/pull/151#issuecomment-1596060662). This PR is now redo to be merged

Improvment to `Array.isArray`

@mattpocock Are the changes in this PR something that will be considered?