Michelle Ark
Michelle Ark
This particular error is probably happening because [`this` was not overwritten](https://github.com/dbt-labs/docs.getdbt.com/pull/4959/files#diff-93cd3964ff9d3a505e3620438d7b0594b473f47a26cec74e57d3c24e36df1a24R313-R316), and the 'real' `is_incremental` macro was attempting to access `this.database`: https://github.com/dbt-labs/dbt-adapters/blob/main/dbt/include/global_project/macros/materializations/models/incremental/is_incremental.sql#L7 > I'm not convinced we should set a...
From refinement: * Can determine whether the model being tested relies on the is_incremental macro based on its depends_on.macros (rather than checking for materialized=incremental, which is less precise) * can...
From refinement: * How do we know which macros are coming from the adapter? Package name + name of current running adapter * This would apply for any macros, as...
Partially resolved by: https://github.com/dbt-labs/dbt-core/issues/9981, which addresses the materialization macros component of this feature request and the will go out in 1.8 and will also be backported to 1.6 and 1.7.
Do we also need to update https://github.com/dbt-labs/dbt-core/blob/main/core/setup.py#L88-L97?
> Any idea why tests/unit/test_plugin_manager.py::TestPluginManager::test_get_nodes is failing across all Python versions here? Discussed offline: It was surprising that the test passed in the first place with `called_once_with`, because there were...
I noticed that part of the acceptance criteria was to ensure that bundles can be created with Python 3.12. Should we confirm that before merging this?
> I intended to merge this PR in, backport the change to 1.7, then test the created bundle for 1.7 with Python 3.12. Sounds great! 💪
May have another use case for this pattern in both: * the upcoming snapshot work * upcoming deprecations corresponding to 'legacy behaviour' ProjectFlags as that pattern becomes more prevalent