Michal-Leszczynski
Michal-Leszczynski
Feel free to ignore my comments if they are not related to this PR. I just wanted to highlight some fields that perhaps require additional attention and give context for...
```go peerSchemasStmt = "SELECT schema_version FROM system.peers" localSchemaStmt = "SELECT schema_version FROM system.local WHERE key='local'" ``` This could be useful.
It will be easier to do after I finish retry policy, which requires changes in receiving Error messages from Scylla. I suggest to wait for this PR first.
We could add SM metric like `scylla_manager_scheduler_status` labeled by `cluster_id`, `task_type`, `task_id` which would store enum of all possible task statuses: ```go // Status enumeration. const ( StatusNew Status =...
Proposed metric wouldn't be labeled by host or table, so it shouldn't generate much entries.
(Incomplete) list of things missing from `DESCRIBE SCHEMA`: - dropped columns - gc_mode (#14390)
> Does it create CQL commands (like cqlsh) or just some internal representation of the schema? If it's the latter, it's not exactly the same thing. When combined with `ToCQL`...
> We have DESC SCHEMA WITH INTERNALS which is supposed to add dropped columns. Does it work? I tried to run those commands viq clqsh with Scylla 5.4.0 with raft...
> Are you using a modern cqlsh which uses the server-side DESC command, or Scylla older cqlsh? Note that the test I mentioned above doesn't use cqlsh - it runs...
But `ALTER TABLE ks.t DROP cf` doesn't fully restore the state of `system_schema.dropped_columns`, because it has a different drop timestamp. Assume the following scenario: - create table (a, b) -...