Michael Simons

Results 145 comments of Michael Simons

I was playing around with the dev UX a bit and was surprised at the overhead prior to when it appears to actually build the test projects in a VMR...

> > I was playing around with the dev UX a bit and was surprised at the overhead prior to when it appears to actually build the test projects in...

Should the build produce the correct multi-arch tags during the "build" phase (e.g. during the post-build leg)? The benefits are that they could be "tested". It would be nice then...

If https://github.com/dotnet/docker-tools/issues/544 is fixed, the tests would more than likely require the multi-arch tags in order to have a static tag that could be referenced.

@joeloff - thanks for keeping source-build in-mind. Source-build already defines a [custom default subset](https://github.com/dotnet/deployment-tools/blob/main/eng/Subsets.props#L42) so no changes should be necessary.

One question is if we would do this for linux only as Windows doesn't have official support for buildx yet (currently in-progress)?

> @MichaelSimons as you predicted, this change didn't impact the older branches but did affect SB in 8+. What's the fix here? Just add the new msbuild bits to the...

> @MichaelSimons adding the line and your update didn't fix the leg either. Any ideas? > > We'll also need to fix #19017 after My change did fix the original...

Those packages will need to be added to https://github.com/dotnet/source-build-reference-packages.

Additionally, it sounds like something with their source build version is creating a need for an unbuntu app host. I'm not sure if that's expected. source-build are RID specific, they...