installer
installer copied to clipboard
dotnet
Update to the shipping version of MSBuild
- Please add description for changes you are making.
- If there is an issue related to this PR, please add the reference.
@MichaelSimons as you predicted, this change didn't impact the older branches but did affect SB in 8+. What's the fix here? Just add the new msbuild bits to the exclusion list? I tried to match the version we're shipping so not sure why an exclusion would be needed for SB.
@MichaelSimons as you predicted, this change didn't impact the older branches but did affect SB in 8+. What's the fix here? Just add the new msbuild bits to the exclusion list? I tried to match the version we're shipping so not sure why an exclusion would be needed for SB.
The corresponding version.details.xml entry needs to be marked as source-build.
Add - <SourceBuild RepoName="msbuild" ManagedOnly="true" />
@MichaelSimons adding the line and your update didn't fix the leg either. Any ideas?
We'll also need to fix #19017 after
@MichaelSimons adding the line and your update didn't fix the leg either. Any ideas?
We'll also need to fix #19017 after
My change did fix the original issue in that the intermediate could not be found. Now there are prebuilts reported.
/__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24179.4/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : 4 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. /__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24179.4/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. /__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24179.4/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : Package IDs are: /__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24179.4/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : System.Configuration.ConfigurationManager.7.0.0 /__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24179.4/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : System.Diagnostics.EventLog.7.0.0 /__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24179.4/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : System.Reflection.MetadataLoadContext.7.0.0 /__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24179.4/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : System.Security.Cryptography.ProtectedData.7.0.0
Those packages will need to be added to https://github.com/dotnet/source-build-reference-packages.
@MichaelSimons coming back to this. Is this what I was supposed to do? https://github.com/dotnet/source-build-reference-packages/pull/943
I wasn't sure what order to add things into the eng/build.props file (and was a bit confused by that file being empty). Running the generate command included a bunch of other edited files but I excluded those from my commit.